[FFmpeg-devel] [PATCH] QSV MJPEG video decoder has been added.

[Michael Niedermayer]

On Sun, Aug 02, 2015 at 09:23:21PM +0300, Ivan Uskov wrote:
> Hello Michael,
> 
> Sunday, August 2, 2015, 8:55:45 PM, you wrote:
> 
> >> +#if QSV_VERSION_ATLEAST(1, 3)
> >> +#include <mfx/mfxjpeg.h>
> >> +#endif
> 
> MN> this seems not working
> 
> MN> CC      libavcodec/qsv.o
> MN> libavcodec/qsv.c:33:25: fatal error: mfx/mfxjpeg.h: No such file or directory
> MN>  #include <mfx/mfxjpeg.h>
> MN>                          ^
> MN> compilation terminated.
> MN> common.mak:57: recipe for target 'libavcodec/qsv.o' failed
> MN> make: *** [libavcodec/qsv.o] Error 1
> 
> 
> MN> /usr/local/include/mfx/mfxvideo.h:#define MFX_VERSION_MAJOR 1
> MN> /usr/local/include/mfx/mfxvideo.h:#define MFX_VERSION_MINOR 10
> MN> /usr/local/include/mfxvideo.h:#define MFX_VERSION_MAJOR 1
> MN> /usr/local/include/mfxvideo.h:#define MFX_VERSION_MINOR 10
> 
> MN> it appears the file was not in mfx_dispatch previously
> MN> so a check in confgure might be needed
> As I can see here
> https://github.com/lu-zero/mfx_dispatch/tree/master/mfx
> The mfxjpeg.h was added 17 days ago and marked  part of API 1.16.
> But really mfxjpeg.h was introduced by Intel at old-old API 1.3 (decoder)
> I do not use mfx_dispatch by myself at all, only native Intel Media
> SDK and patch compiles fine at my side.
> Looks like here some mess from mfx_dispatch side.
> 

> Is there any similar case existing in ffpeg which I can use as
> template to implement own check in configure?

its very simple, see any code using check_header and related functions
in configure
and HAVE_*_H defines

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150802/e3991e3d/attachment.sig>