[FFmpeg-devel] [PATCH] webmdashenc: Fix UTCTiming Element

Michael Niedermayer michaelni at gmx.at
Tue Apr 28 03:59:32 CEST 2015


On Mon, Apr 27, 2015 at 04:26:34PM -0700, Vignesh Venkatasubramanian wrote:
> Remove the direct profile from UTCTiming element. Per DASH spec,
> direct profile value should be the time at which the request was
> made to the server and not the time at which the manifest was
> written. So ffmpeg cannot write this value. This patch removes
> the direct profile and write the UTCTiming element with the http
> profile only if a URL is passed as a parameter. Update the fate
> test to reflect this change.
> 
> Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
> ---
>  libavformat/webmdashenc.c              | 10 +++++-----
>  tests/ref/fate/webm-dash-manifest-live |  3 ---
>  2 files changed, 5 insertions(+), 8 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150428/d5207997/attachment.asc>


More information about the ffmpeg-devel mailing list