[FFmpeg-devel] Patch[2/2]: Fix bug for PPC LE in file libavcodec/ppc/fdctdsp.c

Michael Niedermayer michaelni at gmx.at
Mon Apr 27 13:12:32 CEST 2015

On Mon, Apr 27, 2015 at 02:52:02PM +0800, rongyan wrote:
> Hi,
> GCC tool has a bug of PPC intrinsic interpret, which has been fixed in GCC 4.9.1. This bug lead to errors in two of our previous patches. We found this when we update our GCC tools to 4.9.1 and by reading the related info on GCC website. We fix our previous error in two seperate patches:
> 1. The first patch is to fix libswscale/ppc/swscale_altivec.c by remove the macro GET_VF().
> 2. The second patch is to roll back the commit af5fec9538d88540af5bb2dd0e4b91162ce6fa13 on Apr. 3rd for file libavcodec/ppc/fdctdsp.c, wherer the macros VEC_FMERGEH() and VEC_FMERGEL() are removed.
> This is the second patch.
>  The fate test results on both POWER8 BE and POWER8 LE are as follows:
>  Thanks for your review.
>  Rong Yan

>  fdctdsp.c |   86 ++++++++++++++++++++++++++++----------------------------------
>  1 file changed, 39 insertions(+), 47 deletions(-)
> 0ecce0ae2032c541130d9230f91a4bc962157132  0002-avcodec-ppc-fdctdsp-POWER-LE-support-in-ff_fdct_alti.patch
> From 7f4b56a53262144cfe32788ca2dbea262dbabba7 Mon Sep 17 00:00:00 2001
> From: Rong Yan <rongyan236 at gmail.com>
> Date: Mon, 27 Apr 2015 03:29:51 +0000
> Subject: [PATCH 2/2] avcodec/ppc/fdctdsp: POWER LE support in
>  ff_fdct_altivec() delete macros VEC_FMERGEH() VEC_FMERGEL() for gcc-4.9.1


maybe the functions should be put under #if checks so they arent
used with gcc before 4.9.1 ?



Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150427/fe6e70df/attachment.asc>

More information about the ffmpeg-devel mailing list