[FFmpeg-devel] [PATCH] avformat/atrac3plus: fix compilation warning

Michael Niedermayer michaelni at gmx.at
Thu Apr 23 04:41:22 CEST 2015

On Thu, Apr 23, 2015 at 12:41:39AM +0300, Ilya Gordeev wrote:
> Compiling ffmpeg I'v got this message:
> libavcodec/atrac3plus.c:1784:46: warning: array subscript is below array bounds [-Warray-bounds]
> It's because compiler discards its suggestion about "ctx->num_quant_units" (1<=num_quant_units<=32) when "ctx" passed to "decode_quant_wordlen(gb, ctx, num_channels, avctx)" and anything can happen to fields of "ctx".

i dont understand what you are trying to say

if num_quant_units can be <=0 then theres a bug and i dont see how
your patch fixes such a bug, if not the compiler is broken, and i
dont think we should randomly move code around because of that

which compiler is that ?


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150423/cdb46a82/attachment.asc>

More information about the ffmpeg-devel mailing list