[FFmpeg-devel] [PATCH 5/6] fate: gapless: remove useless tests

[Michael Niedermayer]

On Wed, Apr 22, 2015 at 06:30:29PM +0200, wm4 wrote:
> On Wed, 22 Apr 2015 18:19:02 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > On Wed, Apr 22, 2015 at 12:24:40PM +0200, wm4 wrote:
> > > These could be kept, but they are not overly useful. The only thing they
> > > had over the remaining mp3 gapless test was seeking, which was incorrect
> > > in the toc test, and only by chance correct in the notoc test.
> > > ---
> > >  tests/fate/gapless.mak           | 4 +---
> > >  tests/ref/fate/gapless-mp3-notoc | 5 -----
> > >  tests/ref/fate/gapless-mp3-toc   | 5 -----
> > >  3 files changed, 1 insertion(+), 13 deletions(-)
> > >  delete mode 100644 tests/ref/fate/gapless-mp3-notoc
> > >  delete mode 100644 tests/ref/fate/gapless-mp3-toc
> > 
> > i suggest to keep the test which is correct even when its just by
> > chance unless it breaks for a not easy correctable reason
> > 
> > the test with wrong output should be removed, i agree
> 
> No, they're just useless.

hmm, ok, applied


> If you insist, I can send a patch to re-add a
> seek test with the gapless.mp3 we have. (The existing seek test for mp3
> uses a generated file with plain CBR.)

i dont "insist" but i think its a good idea

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150422/241c6308/attachment.asc>