[FFmpeg-devel] [PATCH] Decoding of Bold-Italic-Underlined styles for 3gpp timed text

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Apr 22 17:27:45 CEST 2015


Niklesh Lalwani <niklesh.lalwani <at> iitb.ac.in> writes:

> +    int i=0;

Usual style is:
int i = 0;

> +        for (i=0; i<style_entries; i++) {

Usual style is:
for (i = 0; i < style_entries; i++) {

Same below.

> +    }
> +    else
> +        text_to_ass(&buf, ptr, end, NULL, NULL, 0, 0);

Please make this:
} else {
    text_to_ass(&buf, ptr, end, NULL, NULL, 0, 0);
}

There is a script tools/patcheck that should 
tell you about such nits.

Carl Eugen



More information about the ffmpeg-devel mailing list