[FFmpeg-devel] [PATCH] webmdashenc: Add minimumUpdatePeriod

Vignesh Venkatasubramanian vigneshv at google.com
Wed Apr 22 01:36:52 CEST 2015


DASH spec requires the presence of either duration of the period
or the minimumUpdatePeriod element. This patch adds the
minimumUpdatePeriod element hardcoded with the value 0 as the
manifest will never be updated for WebM DASH Live streams. Also
updating the fate test reference file.

Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
---
 libavformat/webmdashenc.c              | 3 ++-
 tests/ref/fate/webm-dash-manifest-live | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c
index 6b94e54..e627a15 100644
--- a/libavformat/webmdashenc.c
+++ b/libavformat/webmdashenc.c
@@ -115,7 +115,8 @@ static void write_header(AVFormatContext *s)
             av_strlcpy(gmt_iso, "", 1);
         }
         avio_printf(s->pb, "  availabilityStartTime=\"%s\"\n", gmt_iso);
-        avio_printf(s->pb, "  timeShiftBufferDepth=\"PT%gS\"", w->time_shift_buffer_depth);
+        avio_printf(s->pb, "  timeShiftBufferDepth=\"PT%gS\"\n", w->time_shift_buffer_depth);
+        avio_printf(s->pb, "  minimumUpdatePeriod=\"0\"");
         avio_printf(s->pb, ">\n");
         avio_printf(s->pb, "<UTCTiming\n");
         avio_printf(s->pb, "  schemeIdUri=\"%s\"\n",
diff --git a/tests/ref/fate/webm-dash-manifest-live b/tests/ref/fate/webm-dash-manifest-live
index a6aef97..c682ecc 100644
--- a/tests/ref/fate/webm-dash-manifest-live
+++ b/tests/ref/fate/webm-dash-manifest-live
@@ -7,7 +7,8 @@
   minBufferTime="PT1S"
   profiles="urn:mpeg:dash:profile:isoff-live:2011"
   availabilityStartTime=""
-  timeShiftBufferDepth="PT7200S">
+  timeShiftBufferDepth="PT7200S"
+  minimumUpdatePeriod="0">
 <UTCTiming
   schemeIdUri="urn:mpeg:dash:utc:direct:2012"
   value=""/>
-- 
2.2.0.rc0.207.ga3a616c



More information about the ffmpeg-devel mailing list