[FFmpeg-devel] [PATCH][GSoC] dshow add support for saving and loading of capture devices

[Roger Pack]

OK some verbiage nits:


+ at item capture_audio_device_load
I'd suggest naming it it audio_device_load_from_filename instead.
Similar for video.

+Load an audio capture filter device from file instead of searching
+it by name. It c, if the filter
+supports the serialization of its properties to.
+To use this an audio capture source has to be specified, but it can
+be anything even fake one.

"It may load"

I'd probably say "even a fake one, but we recommend just specifying
the name of the desired device."

+If a file with the same name existed before it will be overwritten.

suggest:

If a file with the same name exists it will be overwritten.

+ at item capture_audio_device_save
suggest rename to audio_device_to_filename, similar for video.

Somehow this diff changed all the line endings so it appears as if the
entire file has changed.  You can use "dos2unix" command to convert
them back then do the diff again, so we can see what really changed.

+        if (file_stream)
+            IStream_Release(file_stream);

I'd prefer to only have this only "once" which means either putting it
in the error:
section
or creating your own error section "error1:" and on failure say "goto
error1" or the like.

GL!

On 4/21/15, Máté Sebők <smfinc.org at gmail.com> wrote:
> This patch allows for saving and loading of audio and video capture filter
> devices (and in some cases its parameters) .
> (similar to IPersistStream, but with the cleaner OleSaveToStream and
> OleLoadFromStream methods)
>
> Regards,
> Máté
>