[FFmpeg-devel] [PATCH v3] libavcodec: Add FLAC API test

[Michael Niedermayer]

On Sun, Apr 19, 2015 at 11:51:52PM +0200, Nicolas George wrote:
> Le primidi 1er floréal, an CCXXIII, Ludmila Glinskih a écrit :
> > ---
> >  libavcodec/Makefile        |   1 +
> >  libavcodec/api-flac-test.c | 290 +++++++++++++++++++++++++++++++++++++++++++++
> >  tests/fate/libavcodec.mak  |   6 +
> >  3 files changed, 297 insertions(+)
> >  create mode 100644 libavcodec/api-flac-test.c
> 
> Can you explain precisely what this program does that can not be done with
> ffmpeg itself?

It can form the basis for testing/comparing various APIs, like
avcodec_decode_audio3() / avcodec_encode_audio() for example
but theres not enough time before the outreachy deadline to add actual
support for these now

[...]
> > +        frame_data[channels * j] = 10000 * ((j / 10 * i) % 2);
> > +        for (k = 1; k < channels; k++)
> 
> > +            frame_data[channels * j + k] = frame_data[channels * j] * 2;
> 
> I do not understand the purpose of that "*2".

i would guess, its intended to generate a signal thats different
for each of the 2 channels, Ludmila can probably confirm/or correct
if its not so

i dont see a problem here, its not the most variied test signal but
for now that should do. It can be chnaged later 

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150420/19aef7c1/attachment.asc>