[FFmpeg-devel] [PATCH 1/4] avformat/mp3dec: fix gapless audio when seeking in CBR mode

Michael Niedermayer michaelni at gmx.at
Fri Apr 17 18:15:39 CEST 2015


On Fri, Apr 17, 2015 at 05:27:00PM +0200, wm4 wrote:
> Removing a bunch of questionable hacks makes it work. These hacks
> apparently try to make concatenated mp3s with Lame headers seekable,
> which doesn't make too much sense anyway. The main change is that we
> trust the Xing header file size field now (the same field is used for
> seeking with Xing TOC). Note that a mp3 might contain an unknown number
> of unsupported additional tags, so we can't reliably compute this size
> manually.
> ---
> Yep, this actually broke gapless again.
> ---
>  libavformat/mp3dec.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

applied

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150417/a512a482/attachment.asc>


More information about the ffmpeg-devel mailing list