[FFmpeg-devel] [libav-devel] [PATCH] aacpsy: avoid norm_fac becoming NaN

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Fri Apr 17 16:08:49 CEST 2015

On 17.04.2015 02:01, Luca Barbato wrote:
> On 16/04/15 20:19, Andreas Cadhalpun wrote:
>> On 16.04.2015 19:41, Claudio Freire wrote:
>>> It should be if band->thr > 0.0f, all divisions by zero return
>>> something that casts into an ~1:
> is band->thr = 0.0f a valid value?

Come to think of it, that's probably invalid.
It can happen if coeffs[g].ath is not positive.
Attached patch errors out in this case.

> band->energy can be 0?

Yes, it's set to 0.0f in calc_thr_3gpp if enough coefs are 0.

Best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-aacpsy-validate-absolute-hearing-threshold.patch
Type: text/x-diff
Size: 1112 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150417/222601af/attachment.bin>

More information about the ffmpeg-devel mailing list