[FFmpeg-devel] [PATCH 2/2] lavf/assenc: handle extra sections after Events

Michael Niedermayer michaelni at gmx.at
Thu Apr 16 21:35:07 CEST 2015


On Thu, Apr 16, 2015 at 05:55:10PM +0200, wm4 wrote:
> On Thu, 16 Apr 2015 10:35:11 -0500
> Rodger Combs <rodger.combs at gmail.com> wrote:
> 
> > 
> > > On Apr 9, 2015, at 06:55, wm4 <nfxjfg at googlemail.com> wrote:
> > > 
> > > On Thu, 9 Apr 2015 06:12:53 -0500
> > > Rodger Combs <rodger.combs at gmail.com> wrote:
> > > 
> > >> 
> > >>> On Apr 8, 2015, at 14:25, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >>> 
> > >>> On Sat, Apr 04, 2015 at 05:31:22AM -0500, Rodger Combs wrote:
> > >>>> ---
> > >>>> libavformat/assenc.c | 28 ++++++++++++++++++++++++++--
> > >>>> 1 file changed, 26 insertions(+), 2 deletions(-)
> > >>> 
> > >>> do you have a testcase for this which you can share ?
> > >>> 
> > >>> [...]
> > >>> 
> > >>> -- 
> > >>> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> > >>> 
> > >>> I have often repented speaking, but never of holding my tongue.
> > >>> -- Xenocrates
> > >>> _______________________________________________
> > >>> ffmpeg-devel mailing list
> > >>> ffmpeg-devel at ffmpeg.org
> > >>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > >> 
> > >> 
> > >> This is the file I was primarily looking at with when writing the patch (received on IRC from a user wanting a fix for this issue): https://dl.dropboxusercontent.com/u/54253260/extra_data_extra_pain.mks <https://dl.dropboxusercontent.com/u/54253260/extra_data_extra_pain.mks>
> > > 
> > > Ah, I think I also had to deal with such a file. IMO it's a muxer bug
> > > to arrange the extradata in this way. Does newest mkvmerge still do
> > > this?
> > > _______________________________________________
> > > ffmpeg-devel mailing list
> > > ffmpeg-devel at ffmpeg.org
> > > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > As discussed on IRC, this is the de-facto standard behavior with ASS. Both ffmpeg and mkvmerge use this format, both internally (extradata) and in MKVs (CodecPrivate).
> 
> Yeah. It's a bit weird, but I'm not opposed.

patch applied

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20150416/d43148e3/attachment.asc>


More information about the ffmpeg-devel mailing list