[FFmpeg-devel] [PATCH] avcodec[/format]/webpenc: use WebPAnimEncoder API to generate animated WebP
urvang at google.com
Thu Apr 16 21:18:25 CEST 2015
Here's the patch without whitespace changes.
On Thu, Apr 16, 2015 at 11:50 AM Urvang Joshi <urvang at google.com> wrote:
> Hi Michael,
> Sorry for my misunderstanding earlier.
> I was told offline that the usual practice in FFmpeg is to land the
> non-whitespace diff first, followed by a separate reindent commit.
> Let me separate out the two and send the non-whitespace diff shortly.
> On Thu, Apr 16, 2015 at 11:35 AM Urvang Joshi <urvang at google.com> wrote:
>> Hello Michael,
>> On Thu, Apr 16, 2015 at 5:26 AM Michael Niedermayer <michaelni at gmx.at>
>>> On Thu, Apr 16, 2015 at 12:28:22AM +0000, Urvang Joshi wrote:
>>> > Hi,
>>> > Here's an updated patch that used 'HAVE_WEBP_MUX_H' as you suggested. I
>>> > also updated the patch to work with the latest libwebp code (from
>>> > https://gerrit.chromium.org/gerrit/gitweb?p=webm/libwebp.git)
>>> please dont reindent the code in the same commit that contains
>>> non cosmetic changes, it makes the patch unreadable
>>> git show --stat -w
>>> configure | 5 ++-
>>> libavcodec/libwebpenc.c | 93
>>> libavformat/webpenc.c | 44 +++++++++++++++++++++-
>>> 3 files changed, 132 insertions(+), 10 deletions(-)
>>> git show --stat
>>> configure | 5 +-
>>> libavcodec/libwebpenc.c | 399
>>> libavformat/webpenc.c | 44 +++++-
>>> 3 files changed, 285 insertions(+), 163 deletions(-)
>> Thanks for taking a look!
>> However, note that these whitespace changes are not actually cosmetic.
>> Some code was moved inside if-else within libwebp_encode_frame() method [in
>> libavcodec/libwebpenc.c], which resulted in the indentation being increased.
>> Overall, there are no intended cosmetic changes. Please let me know if
>> you see any.
>>> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>> Those who are too smart to engage in politics are punished by being
>>> governed by those who are dumber. -- Plato
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8745 bytes
Desc: not available
More information about the ffmpeg-devel