[FFmpeg-devel] [PATCH] avcodec/libx265: print supported presets and tunes on error

James Almer jamrial at gmail.com
Fri Apr 10 18:16:40 CEST 2015


On 10/04/15 12:39 PM, Derek Buitenhuis wrote:
> On 4/10/2015 6:34 AM, James Almer wrote:
>> Based on code from libavcodec/libx264.c
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/libx265.c | 11 ++++++++++-
>>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> LGTM if you add some newlines so it isn't all smushed together.
> 
> - Derek

With the patch as is it looks like this:

[libx265 @ 0000000001b3a500] Error setting preset/tune foo/bar.
[libx265 @ 0000000001b3a500] Possible presets: ultrafast superfast veryfast faster fast medium slow slower veryslow placebo
[libx265 @ 0000000001b3a500] Possible tunes: psnr ssim grain zerolatency fastdecode

Where do you want the extra newlines? After each colon?


More information about the ffmpeg-devel mailing list