[FFmpeg-devel] [PATCH 2/2] webmdashenc: Support for live stream manifests

[Vignesh Venkatasubramanian]

On Tue, Mar 31, 2015 at 6:45 PM, Timothy Gu <timothygu99 at gmail.com> wrote:
>
>
> On Tue, Mar 31, 2015 at 5:11 PM Vignesh Venkatasubramanian
> <vigneshv at google.com> wrote:
>>
>> This patch adds support for creating DASH manifests for WebM Live
>> Streams. It also updates the documentation and adds a fate test to
>> verify the behavior of the new muxer flag.
>>
>> Signed-off-by: Vignesh Venkatasubramanian <vigneshv at google.com>
>> ---
>>  doc/muxers.texi                        |  27 ++++-
>>  libavformat/webmdashenc.c              | 191
>> ++++++++++++++++++++++++++++-----
>>  tests/fate/vpx.mak                     |   3 +
>>  tests/ref/fate/webm-dash-manifest-live |  26 +++++
>>  4 files changed, 219 insertions(+), 28 deletions(-)
>>  create mode 100644 tests/ref/fate/webm-dash-manifest-live
>>
>> diff --git a/doc/muxers.texi b/doc/muxers.texi
>> index a8225fc..089af06 100644
>> --- a/doc/muxers.texi
>> +++ b/doc/muxers.texi
>> @@ -1210,7 +1210,11 @@ is the @option{global_header} flag.
>>
>>  WebM DASH Manifest muxer.
>>
>> -This muxer implements the WebM DASH Manifest specification to generate
>> the DASH manifest XML.
>> +This muxer implements the WebM DASH Manifest specification to generate
>> the DASH
>> +manifest XML. It also supports manifest generation for DASH live streams.
>> +
>> +WebM DASH Specification:
>> @url{https://sites.google.com/a/webmproject.org/wiki/adaptive-streaming/webm-dash-specification}
>> +ISO DASH Specification:
>> @url{http://standards.iso.org/ittf/PubliclyAvailableStandards/c065274_ISO_IEC_23009-1_2014.zip}
>
>
> Seriously? I know Texinfo is a relatively obscure format, but that is why
> you need to check the HTML output to make sure it's pretty (enough).

Sorry. I've changed it as you suggested and saw the HTML. It looks
fine now. Thanks!

>
> Do this:
>
> For more information, see:
>
> @itemize @bullet
>
> @item
>
> WebM DASH…
>
> @item
>
> ISO DASH…
>
> @end itemize
>
>
>>
>>  @subsection Options
>>
>> @@ -1221,6 +1225,27 @@ This muxer supports the following options:
>>  This option has the following syntax: "id=x,streams=a,b,c
>> id=y,streams=d,e" where x and y are the
>>  unique identifiers of the adaptation sets and a,b,c,d and e are the
>> indices of the corresponding
>>  audio and video streams. Any number of adaptation sets can be added using
>> this option.
>> +
>> + at item live
>> +Set this to 1 to create a live stream DASH Manifest. Default: 0.
>> +
>
>
>>
>> + at item chunk_start_index
>> +Start index of the first chunk. This will go in the "startNumber"
>> attribute of
>> +the "SegmentTemplate" element in the manifest. Default: 0.
>> +
>> + at item chunk_duration_ms
>> +Duration of each chunk in milliseconds. This will go in the "duration"
>> attribute
>> +of the "SegmentTemplate" element in the manifest. Default: 1000.
>> +
>> + at item utc_timing_url
>> +URL of the page that will return the UTC timestamp in ISO format. This
>> will go
>> +in the "value" attribute of the "UTCTiming" element in the manifest.
>> Default:
>> +None.
>
>
> Change all the quotes to @samp{UTCTiming etc.} please.
>

Done. Please take another look.

> […]
>
> Timothy



-- 
Vignesh