[FFmpeg-devel] [PATCH] avformat: remove FF_API_ASS_SSA dead code

[Clément Bœsch]

On Mon, Sep 22, 2014 at 02:53:12PM +0000, Rainer Hochecker wrote:
> Clément Bœsch <u <at> pkh.me> writes:
> 
> 
> > > 
> > > +1
> > 
> > Applied
> > 
> 
> 
> We at XBMC got the first complaints about broken subtitles. Why was this
> removed?

Hi,

We just made the ASS packets from the Matroska output them verbatim, and
not hacked with timestamps included into the timestamps.

The packets are now typically broadcastable to libass.

Note that this change has been documented since 2.0; doc/APIchanges states:

    2013-04-18 - 7c1a002 - lavf 55.3.100
      The matroska demuxer can now output proper verbatim ASS packets. It will
      become the default starting lavf 56.0.100.

It was also mentioned in the RELEASE_NOTES of 2.4 after the bump:
http://git.videolan.org/?p=ffmpeg.git;a=blob;f=RELEASE_NOTES;hb=HEAD#l40

I'm sorry about the compatibility break but we had to move on, and I believe it
was done in a proper way (slow and documented, while providing benefits for the
end user at the same time)

Best regards,

PS: this commit didn't disable the code, it was disabled since last bump, which
means in 2.4

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140922/c775df54/attachment.asc>