[FFmpeg-devel] [PATCH 1/4] avformat/utils: return EINVAL from seek_frame_generic() when the requested target appears to be outside the file duration

Reimar Döffinger Reimar.Doeffinger at gmx.de
Thu Sep 11 20:08:43 CEST 2014


On Thu, Sep 11, 2014 at 04:48:00PM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>

Isn't that potentially a bit confusing?
EINVAL sounds to me like I would expect a programming error,
inputting something I should have known to be invalid.
That's not quite the case for out-of-range timestamps.
I guess it is better than -1 though, and I can't suggest
anything better, I am just not really happy with it.


More information about the ffmpeg-devel mailing list