[FFmpeg-devel] [PATCH] avcodec/hevc_ps: Always initialize backup in decode_vui()

Christophe Gisquet christophe.gisquet at gmail.com
Sat Sep 6 13:28:41 CEST 2014


2014-09-06 12:40 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> -    // Backup context in case an alternate header is detected
> -    if( get_bits_left(gb) >= 66)
> -        memcpy(&backup, gb, sizeof(backup));
> +    memcpy(&backup, gb, sizeof(backup));

I know people consider obvious comments to waste screen space, but I'd
prefer more than fewer comments on this.

What about leaving it?

Otherwise, ok, and sorry for the original buggy code.

-- 
Christophe


More information about the ffmpeg-devel mailing list