[FFmpeg-devel] [PATCH 3/4] libswresample: Avoid needlessly large on-stack array.

[Reimar Döffinger]

On 03.09.2014, at 06:28, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Sep 03, 2014 at 12:01:54AM +0200, Reimar Döffinger wrote:
>> We only actually use a tiny part of it.
>> 
>> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
>> ---
>> libswresample/rematrix.c | 7 ++++---
>> 1 file changed, 4 insertions(+), 3 deletions(-)
> 
> i think there a multiple loops left that can access more of the array
> 
> 2 i spotted:
> for(i=0; i<64; i++){
>        if(in_ch_layout & out_ch_layout & (1ULL<<i))
>            matrix[i][i]= 1.0;
>    }

Seems I missed that somehow. That one might be a bit of a mess.

> if(s->rematrix_volume > 0){
>        for(i=0; i<SWR_CH_MAX; i++)
>            for(j=0; j<SWR_CH_MAX; j++){
>                s->matrix[i][j] *= s->rematrix_volume;
>            }
>    }

That is s->matrix?