[FFmpeg-devel] [PATCH] rl.h: Allocate temporary VLC tables instead of having them static.

Michael Niedermayer michaelni at gmx.at
Mon Sep 1 12:05:00 CEST 2014


On Mon, Sep 01, 2014 at 09:32:56AM +0200, Reimar Döffinger wrote:
> On 01.09.2014, at 02:35, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sun, Aug 31, 2014 at 08:27:17PM +0200, Reimar Döffinger wrote:
> >> 
> >> {
> >>     int i, q;
> >> +    VLC vlc;
> > 
> >> +    init_vlc(&vlc, 9, rl->n + 1, &rl->table_vlc[0][1], 4, 2, &rl->table_vlc[0][0], 4, 2, 0);
> > 
> > same issue here
> > 
> > why do you change the code to dynamically allocate ?
> 
> Because it ends up using and wasting memory for nothing at runtime if you leave it static.
> And the size is a bit too large to do it on-stack I think.

maybe iam missing something but does it need more than 5kb ?
or is that considered "too much" for some supported platform ?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140901/31ce6b96/attachment.asc>


More information about the ffmpeg-devel mailing list