[FFmpeg-devel] [PATCH] libxcb-xhsape in configure

[Carl Eugen Hoyos]

Hi!

On Thursday 30 October 2014 09:26:16 pm Horváth Balázs wrote:
> This is my attempt at fixing the broken build because xcbgrab
> uses xcb_shape_rectangles, but doesn't link xcb-shape.

Do you consider the attached patch a sufficient fix? Or does 
it have an advantage for users to disable xcb-shape but enable 
xcb-xfixes?

Thank you, Carl Eugen
-------------- next part --------------
diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c
index 2fdb992..9a67985 100644
--- a/libavdevice/xcbgrab.c
+++ b/libavdevice/xcbgrab.c
@@ -576,7 +576,7 @@ static void setup_window(AVFormatContext *s)
                       XCB_COPY_FROM_PARENT,
                       mask, values);
 
-#if XCB_SHAPE_RECTANGLES
+#if CONFIG_LIBXCB_XFIXES
     xcb_shape_rectangles(c->conn, XCB_SHAPE_SO_SUBTRACT,
                          XCB_SHAPE_SK_BOUNDING, XCB_CLIP_ORDERING_UNSORTED,
                          c->window,