[FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

[Michael Niedermayer]

On Sat, Oct 25, 2014 at 06:25:22PM +0200, Reimar Döffinger wrote:
> On Sat, Oct 25, 2014 at 05:35:37PM +0200, Christophe Gisquet wrote:
> > 2014-10-25 13:35 GMT+02:00 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> > > Could you maybe add e.g. a FATE test that clearly shows the before-after
> > > improvements?
> > 
> > I've tried for a small while, by swapping fields on lena and converting to
> > yuv42[02]p and feeding it to ffmpeg with:
> > -pix_fmt yuv422p -s 720x576 -i lena.yuv -flags ildct -vf
> > "setfield=1,fieldorder=bff" -vcodec dvvideo out.dv
> > The PSNR results were weird (with 2 exes I thought were before/after), so I
> > didn't follow through. Maybe someone more versed in libavfi can offer a
> > command-line doing the job.
> > 
> > The only conclusive impact is on the #2970 sequence, but it has too few
> > blocks coded as interlaced (!) to matter for anything but visual. And
> > indeed the fate tests do not seem to exercise the affected code.
> 
> Maybe I misunderstand the issue, but maybe a encoder option
> to force interlaced encoding would work to trigger this reliably?

I took the liberty to apply the patch and fix the bug instead of
leaving it open until someone succeeds writing a fate test for it


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141026/2b4b8761/attachment.asc>