[FFmpeg-devel] [PATCH] lavfi: add xbr filter

Nicolas George george at nsup.org
Sat Oct 25 20:07:59 CEST 2014


Le quartidi 4 brumaire, an CCXXIII, arwa arif a écrit :
> Can you please specify what is meant by stand-alone changes?

I believe it was already specified in my original message: "such as moving
code into a shared function", and pore importantly: "it does not seem to
apply here".

> Apart from that, I have updated the patch.

I have no further remarks about commit organization. The doc looks fine too,
except a small nitpick: capitalization should follow the name of the filter
in filter graphs, all lowercase.

I will leave others comment the actual code.

Thanks.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141025/401d3ab0/attachment.asc>


More information about the ffmpeg-devel mailing list