[FFmpeg-devel] [PATCH 4/6] dv: fix weight table for 2x4x8 transform

[Christophe Gisquet]

2014-10-25 13:35 GMT+02:00 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> Could you maybe add e.g. a FATE test that clearly shows the before-after
> improvements?

I've tried for a small while, by swapping fields on lena and converting to
yuv42[02]p and feeding it to ffmpeg with:
-pix_fmt yuv422p -s 720x576 -i lena.yuv -flags ildct -vf
"setfield=1,fieldorder=bff" -vcodec dvvideo out.dv
The PSNR results were weird (with 2 exes I thought were before/after), so I
didn't follow through. Maybe someone more versed in libavfi can offer a
command-line doing the job.

The only conclusive impact is on the #2970 sequence, but it has too few
blocks coded as interlaced (!) to matter for anything but visual. And
indeed the fate tests do not seem to exercise the affected code.

--
Christophe