[FFmpeg-devel] [PATCH 1/2] rtsp: pass return code from ffurl_open() on its failure

[Michael Niedermayer]

On Fri, Oct 24, 2014 at 12:39:21AM +0400, Andrey Utkin wrote:
> On Thu, Oct 23, 2014 at 10:23 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > why doesnt this write into err directly without ret ?
> 
> ffurl_open() returns >= 0 in case of success.
> Positive value of err can be confusing and can lead to unexpected
> behaviour, also at future changes (the modified function is quite
> large, so hard for thorough reviewing and accounting of all cases).
> So i did it this way to avoid introduction of any side effects.

hmm, ok
patch applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141023/673fb49e/attachment.asc>