[FFmpeg-devel] [PATCH 4/4] ffserver_config: postpone codec context creation

[Reynaldo H. Verdejo Pinochet]

Hi

On 10/20/2014 06:57 PM, Lukasz Marek wrote:
> So far AVCodecContext was created without codec specified.
> This causes internal data to not be initialized to defaults.
> 
> This commit postpone context creation until all information are gathered.

are/is

> 
> Partially fixes #1275
> ---
>  ffserver.c        |   8 +-
>  ffserver_config.c | 286 ++++++++++++++++++++++++++++++++----------------------
>  ffserver_config.h |   9 +-
>  3 files changed, 183 insertions(+), 120 deletions(-)
> 
> diff --git a/ffserver.c b/ffserver.c
> index 22560ce..8c65d12 100644
> --- a/ffserver.c
> +++ b/ffserver.c
> @@ -212,8 +212,12 @@ static FFServerConfig config = {
>      .warnings = 0,
>      .audio_id = AV_CODEC_ID_NONE,
>      .video_id = AV_CODEC_ID_NONE,
> -    .audio_enc = {0},
> -    .video_enc = {0},
> +    .video_opts = NULL,
> +    .video_conf = NULL,
> +    .audio_opts = NULL,
> +    .audio_conf = NULL,
> +    .video_preset = NULL,
> +    .audio_preset = NULL,
>  };
>  

Guess you are already considered dropping the explicit initialization
code as Reimaer suggested.

Looks good otherwise. Feel free to push.

Bests,

-- 
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley