[FFmpeg-devel] patch: fix buf in configure to ensure theHAVE_VSX is only enabled when HAVE_ALTIVECT is enabled

[rongyan]

Hi,
 Since the code HAVE_VSX covered is part of the altivec implementation, but not a independent implementaiton for all the code covered by macro HAVE_ALTIVEC. If HAVE_ALTIVEC is disabled, but only HAVE_VSX is enabled, the code will crash.
 Thanks.
  
 Rong Yan
  
 ------------------ 
   The world has enough for everyone's need, but not enough for everyone's greed.



  
  

 

 ------------------ Original ------------------
  From:  "michaelni";<michaelni at gmx.at>;
 Date:  Tue, Oct 14, 2014 11:10 PM
 To:  "FFmpeg development discussions and patches"<ffmpeg-devel at ffmpeg.org>; "rongyan"<rongyan236 at foxmail.com>; 
 
 Subject:  Re: [FFmpeg-devel] patch: fix buf in configure to ensure theHAVE_VSX is only enabled when HAVE_ALTIVECT is enabled

 

On Mon, Oct 13, 2014 at 04:14:57PM +0800, rongyan wrote:
> Reimar,
>  HAVE_VSX is used to make PPC ALTIVEC code successfully running in LE.
>  Yes, we can add some comment to the configure.

i belive the question reimar had was

why VSX is not enabled when altivec is disabled ?
or the same from another viewpoint
if VSX implies altivec


[...]
> Sorry if my question makes no sense (I am fairly clueless about little-endian PPC), but why is it necessary to disable vsx if altivec is disabled?
> It would be good to add that e.g. as a comment to configure (unless it's some obvious reason I missed).

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope