[FFmpeg-devel] [PATCH 4/6] h264_changesps_bsf: fix compilation

Christophe Gisquet christophe.gisquet at gmail.com
Sun Nov 30 10:26:29 CET 2014


Hi,

2014-11-30 2:11 GMT+01:00 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Christophe Gisquet <christophe.gisquet <at> gmail.com> writes:
>
>>  libavcodec/h264_changesps_bsf.c | 24 +++---------------------
>>  1 file changed, 3 insertions(+), 21 deletions(-)
>
> Please merge this into the earlier patch, as-is
> regression tests are unnecessarily hard.

Sure, it's just that I wanted to keep the original author code (some
people prefer squashing together those kinds of patches, but I hate
that). And doing so perfectly means here introducing
broken/unacceptable code just to remove it in the next patch.

On the other hand, that's what usually signed-off-by means in a squashed patch.

So, now that I made publicly clear this is what has been done, I'll
squash this one and the next one into the previous one.

-- 
Christophe


More information about the ffmpeg-devel mailing list