[FFmpeg-devel] [PATCH] Fix undefined reference to xcb_shape_rectangles in xcbgrab.c

[Michael Niedermayer]

Hi

On Sun, Nov 23, 2014 at 02:48:54PM -0600, Boris Reisig wrote:
> It seems when using the latest ffmpeg from master git, there's an
> incompatible change in the last few weeks that prevents libxcb-shape
> from being detected properly in ffmpeg so it wouldn't compile
> properly.  I have written a patch to fix the detection to make
> ffmpeg compile properly.
> 
> 
> Example if if failing to compile.
> 
> INSTALL doc/libavcodec.3
> INSTALL doc/libavformat.3
> INSTALL doc/libavdevice.3
> INSTALL doc/libavfilter.3
> LD      ffmpeg_g
> libavdevice/libavdevice.a(xcbgrab.o): In function `xcbgrab_read_header':
> xcbgrab.c:(.text.unlikely+0x52c): undefined reference to
> `xcb_shape_rectangles'
> collect2: error: ld returned 1 exit status
> Makefile:122: recipe for target 'ffmpeg_g' failed
> make: *** [ffmpeg_g] Error 1

a quite similar patch was already posted, and i have the same question
as with that one, does this work with --disable-libxcb-shape ?

Please someone confirm that it does work with --disable-libxcb-shape
or if not please adjust the patch so it does something appropriate
also carl has posted a untested alternative patch in the previous
thread "[FFmpeg-devel] [PATCH] libxcb-xhsape in configure"
i really would like to apply a fix for this but i need a bit feedback
on which is best and what works

Thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141124/20cd798d/attachment.asc>