[FFmpeg-devel] [PATCH 1/1] ffv1dec: Avoid unnecessarily large stack usage and copies.

Michael Niedermayer michaelni at gmx.at
Sat Nov 22 14:42:25 CET 2014


On Sat, Nov 22, 2014 at 02:14:13PM +0100, Reimar Döffinger wrote:
> Ideally the compiler could figure this out on its own,
> but it seems it can't.
> An alternative that would avoid the messy explicit memcpy
> would be to use a sub-struct for the parts that should
> be preserved, which can then simply be assigned.
> 
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> ---
>  libavcodec/ffv1dec.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141122/886a2468/attachment.asc>


More information about the ffmpeg-devel mailing list