[FFmpeg-devel] Patch mpegts_start_pid to allow ATSC PID ranges

Michael Niedermayer michaelni at gmx.at
Wed Nov 19 00:56:28 CET 2014


On Tue, Nov 18, 2014 at 01:56:21PM -0800, Zach Swena wrote:
> Sorry, I am new to using Git.  I have a .patch file, but I am not sure what
> the proper way to send it is.  I am using GitHub for windows.  Anyway, the
> .patch file is attached.
> 
> Zach
> 
> 
> 
> On Tue, Nov 18, 2014 at 10:33 AM, Timothy Gu <timothygu99 at gmail.com> wrote:
> 
> > Hi,
> >
> > On Tue, Nov 18, 2014 at 9:02 AM, Zach Swena <zcybercomputing at gmail.com>
> > wrote:
> > > Hi,
> > >
> > > Here is a patch to allow FFmpeg to use PID ranges compatible with ATSC
> > > television.  I based the new minimum value on the PID ranges here
> > > <http://en.wikipedia.org/wiki/MPEG_transport_stream>on wikipedia.  This
> > > should be sufficient to allow the use of any standard PID used in ATSC
> > > television.
> > >
> > > Zach
> > >
> > > As Attached:
> > > in mpegtsenc.c line
> > >
> > > 1441c1441
> > > <       { .i64 = 0x0100 }, 0x0100, 0x0f00, AV_OPT_FLAG_ENCODING_PARAM },
> > > ---
> > >>       { .i64 = 0x0100 }, 0x0020, 0x0f00, AV_OPT_FLAG_ENCODING_PARAM },
> > >
> >
> > We only read Git unified patches. `git commit` and `git format-patch -1`
> >
> > Timothy
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >

>  mpegtsenc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> eec00a02476529142a50aac8b0e2bbaf5780df8b  0001-min-value-for-mpegts_start_pid-to-allow-ATSC-PIDs.patch
> From dcd75a7f912a0a7e14314e9c66a6f9cf67351934 Mon Sep 17 00:00:00 2001
> From: dedicatedbroadcastsolutions <zcybercomputing at gmail.com>
> Date: Tue, 18 Nov 2014 13:43:07 -0800
> Subject: [PATCH] min value for mpegts_start_pid to allow ATSC PIDs

patch applied


> 
> Here is a patch to allow FFmpeg to use PID ranges compatible with ATSC
> television.  I based the new minimum value on the PID ranges on
> wikipedia.  This should be sufficient to allow the use of any standard
> PID used in ATSC television.

wikipedia is generally not a good choice for these things.
Whenever possible the actual specifications (or drafts) should be
checked
but either way its better to allow the user to choose lower pids if
thats what (s)he wants ...

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141119/165a5715/attachment.asc>


More information about the ffmpeg-devel mailing list