[FFmpeg-devel] [PATCH 06/11] [WIP][RFC]tools: add ffserver_config_test

[Reynaldo H. Verdejo Pinochet]

Hi. Overall this looks good, thanks. I would move the test to
tests/ though and integrate it with the build/test system as,
say, the way tiny_ssim is:

grep -R tiny_ssim *
Makefile:TESTTOOLS   = audiogen videogen rotozoom tiny_psnr tiny_ssim base64
tests/Makefile:FATE_UTILS = base64 tiny_psnr tiny_ssim
tests/tiny_ssim.c: * tiny_ssim.c
tests/tiny_ssim.c:        printf("tiny_ssim <file1.yuv> <file2.yuv>
<width>x<height> [<seek>]\n");

Small nit bellow while I'm at this:


On 11/16/2014 10:46 PM, Lukasz Marek wrote:
> [..]
> @@ -1205,3 +1205,43 @@ int ffserver_parse_ffconfig(const char *filename, FFServerConfig *config)
>  
>  #undef ERROR
>  #undef WARNING
> +
> +static void ffserver_free_server_stream(FFServerStream *stream)
> +{
> +    int i;
> +
> +    av_dict_free(&stream->in_opts);
> +    av_dict_free(&stream->metadata);
> +    while(stream->acl) {

You seem to use an space before ( for if/while/for. Add it here.

Bests,

-- 
Reynaldo H. Verdejo Pinochet
Open Source Group
Samsung Research America / Silicon Valley