[FFmpeg-devel] ffmpeg git hooks

Jean-Baptiste Kempf jb at videolan.org
Tue Nov 11 20:35:08 CET 2014


Hello,

Done.

On 11 Nov, Michael Niedermayer wrote :
> Hi roots at vlc
> 
> On Mon, Nov 10, 2014 at 12:04:25PM +0100, Michael Niedermayer wrote:
> > Hi
> > 
> > Are the hooks which are used for ffmpeg git publically visible
> > somewhere ?
> > iam asking as we would like to submit patches to fix some issues
> > in them.
> > For example we would like to add tests/fate/*.mak to the exceptions
> > which allow tabs
> 
> Please apply the 2 attached patches to the ffmpeg git hook
> 
> Thanks
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> What does censorship reveal? It reveals fear. -- Julian Assange

> From 43343a85f6909e501f8dbb5b6cea8ddc07c2be1f Mon Sep 17 00:00:00 2001
> From: Michael Niedermayer <michaelni at gmx.at>
> Date: Mon, 10 Nov 2014 14:54:54 +0100
> Subject: [PATCH 1/3] allow tabs in *.mak, they are part of the makefile
>  syntax
> 
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  update |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/update b/update
> index 86d51db..92e645d 100644
> --- a/update
> +++ b/update
> @@ -67,7 +67,7 @@ check_ending_newline () {
>  
>  
>  check_tabs () {
> -  for file in $(git diff-tree --name-only --diff-filter="A|C|M|R" -r $REVISION | tail -n +2 | egrep -v 'Makefile.*|common.mak|library.mak|subdir.mak|clean-diff|\.diff|\.patch' | egrep "$@") ; do
> +  for file in $(git diff-tree --name-only --diff-filter="A|C|M|R" -r $REVISION | tail -n +2 | egrep -v 'Makefile.*|common.mak|library.mak|subdir.mak|clean-diff|\.diff|\.patch|\.mak' | egrep "$@") ; do
>      if is_text_file $REVISION "$file" 2> /dev/null ; then
>        if git cat-file -p "$REVISION:$file" | grep -e '	' > /dev/null; then
>          echoerr "In $REVISION:"
> -- 
> 1.7.9.5
> 

> From 4b04f8df0e8a2779e022e92f73405f4b3376e175 Mon Sep 17 00:00:00 2001
> From: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> Date: Tue, 11 Nov 2014 00:41:50 +0100
> Subject: [PATCH 3/3] allow fate references to lack the final newline
> 
> ---
>  update |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/update b/update
> index 69b3b38..2612365 100644
> --- a/update
> +++ b/update
> @@ -53,7 +53,7 @@ check_trailing_whitespace () {
>  }
>  
>  check_ending_newline () {
> -  for file in $(git diff-tree --name-only --diff-filter="A|C|M|R" -r $REVISION | tail -n +2 | egrep -v '/$|\.diff$|\.patch$' | egrep "$@") ; do
> +  for file in $(git diff-tree --name-only --diff-filter="A|C|M|R" -r $REVISION | tail -n +2 | egrep -v '/$|^tests/ref/|\.diff$|\.patch$' | egrep "$@") ; do
>      if is_text_file $REVISION "$file" 2> /dev/null ; then
>        if [ `git cat-file -p "$REVISION:$file" | tail -c1 | wc -l` = 0 ]; then
>          echoerr "In $REVISION:"
> -- 
> 1.7.9.5
> 




-- 
With my kindest regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device


More information about the ffmpeg-devel mailing list