[FFmpeg-devel] [PATCH] swscale: fix yuv2yuvX_8 assembly on x86

[James Almer]

On 09/11/14 5:28 PM, Michael Niedermayer wrote:
> On Sun, Nov 09, 2014 at 08:39:35PM +0100, Kieran Kunhya wrote:
>> ---
>>  libswscale/x86/swscale.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c
>> index 8ce87b3..c9f3b1a 100644
>> --- a/libswscale/x86/swscale.c
>> +++ b/libswscale/x86/swscale.c
>> @@ -430,7 +430,7 @@ switch(c->dstBpc){ \
>>      case 16:                          do_16_case;                          break; \
>>      case 10: if (!isBE(c->dstFormat)) vscalefn = ff_yuv2planeX_10_ ## opt; break; \
>>      case 9:  if (!isBE(c->dstFormat)) vscalefn = ff_yuv2planeX_9_  ## opt; break; \
>> -    default: if (condition_8bit)    /*vscalefn = ff_yuv2planeX_8_  ## opt;*/ break; \
>> +    case 8: if (condition_8bit)      vscalefn = ff_yuv2planeX_8_  ## opt; break; \
> 
> doesnt work:
> for example this generates a funny colored output and seems to not
> look the same when run multiple times
> ffmpeg -f lavfi -i testsrc -t 1 test.avi

Fate passes with this patch applied. Shouldn't a test that can detect this be added then?