[FFmpeg-devel] [PATCH] ffmpeg_opt: set correct priv_data for feed stream

[Michael Niedermayer]

On Thu, Nov 06, 2014 at 12:59:45AM +0100, Lukasz Marek wrote:
> new_output_stream creates a codec context with arbitraty picked codec.
> Later data is updated, but priv_data are left alone.
> There is a bit chance there is a mismatch between codecs.
> 
> Signed-off-by: Lukasz Marek <lukasz.m.luki2 at gmail.com>
> ---
>  ffmpeg_opt.c         | 16 ++++++++++++++++
>  libavformat/ffmdec.c |  6 ++++--
>  2 files changed, 20 insertions(+), 2 deletions(-)

with this fate-lavf-ffm crashes

==10836== Invalid write of size 8
==10836==    at 0x935442: decode_init (mpegaudiodec_template.c:419)
==10836==    by 0xA69226: avcodec_open2 (utils.c:1614)
==10836==    by 0x64CC5F: avformat_find_stream_info (utils.c:3053)
==10836==    by 0x41C2D7: open_input_file (ffmpeg_opt.c:886)
==10836==    by 0x42427A: open_files (ffmpeg_opt.c:2699)
==10836==    by 0x4243F8: ffmpeg_parse_options (ffmpeg_opt.c:2736)
==10836==    by 0x43762E: main (ffmpeg.c:3861)
==10836==  Address 0x10f072b0 is not stack'd, malloc'd or (recently) free'd
==10836==
==10836== Invalid write of size 8
==10836==    at 0xDC67D0: avpriv_float_dsp_init (float_dsp.c:120)
==10836==    by 0x93546B: decode_init (mpegaudiodec_template.c:421)
==10836==    by 0xA69226: avcodec_open2 (utils.c:1614)
==10836==    by 0x64CC5F: avformat_find_stream_info (utils.c:3053)
==10836==    by 0x41C2D7: open_input_file (ffmpeg_opt.c:886)
==10836==    by 0x42427A: open_files (ffmpeg_opt.c:2699)
==10836==    by 0x4243F8: ffmpeg_parse_options (ffmpeg_opt.c:2736)
==10836==    by 0x43762E: main (ffmpeg.c:3861)
==10836==  Address 0x10f072e8 is not stack'd, malloc'd or (recently) free'd
and pages more

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141106/6cb40db8/attachment.asc>