[FFmpeg-devel] [PATCH] [RFC] avformat: use "genpts" option for output file.

Michael Niedermayer michaelni at gmx.at
Tue Nov 4 14:08:29 CET 2014


On Tue, Nov 04, 2014 at 01:15:02PM +0100, Benoit Fouet wrote:
> Hi,
> 
> ----- Mail original -----
> > On Mon, Nov 03, 2014 at 03:21:33PM +0100, Benoit Fouet wrote:
> > > When "-fflags +genpts" is used for output file, use dts as pts.
> > > 
> > > Signed-off-by: Benoit Fouet <benoit.fouet at free.fr>
> > > ---
> > >  libavformat/mux.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/libavformat/mux.c b/libavformat/mux.c
> > > index 5e45bd8..1d42451 100644
> > > --- a/libavformat/mux.c
> > > +++ b/libavformat/mux.c
> > > @@ -884,6 +884,9 @@ int av_interleaved_write_frame(AVFormatContext
> > > *s, AVPacket *pkt)
> > >              ret = AVERROR(EINVAL);
> > >              goto fail;
> > >          }
> > > +
> > > +        if (pkt->pts == AV_NOPTS_VALUE && s->flags &
> > > AVFMT_FLAG_GENPTS)
> > > +            pkt->pts = pkt->dts;
> > 
> > does this set pts to invalid value for h264 with b frames or
> > b pyramid ?
> > 
> 
> No.

how did you test this ?
can you show an example of b pyramid and the filled in PTS values


> The only thing I wanted to do was to provide a way for users to remux h264 elementary streams to .ts or .mkv
> Maybe I could add a new option, like +copy_dts_to_pts instead of using the existing +genpts option?
>
> --
> Ben
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20141104/e4641ac0/attachment.asc>


More information about the ffmpeg-devel mailing list