[FFmpeg-devel] [PATCH] ffserver_config: improve AVOption handing

Lukasz Marek lukasz.m.luki2 at gmail.com
Mon Nov 3 00:35:53 CET 2014


On 02.11.2014 22:37, Reynaldo H. Verdejo Pinochet wrote:
> If you are always returning 0 then this func should probably be
> declared static void instead?

I left it as int for future, but probably no reason for that, so changed.

>> [..]
>> diff --git a/ffserver_config.h b/ffserver_config.h
>> index f29f07f..c684fb5 100644
>> --- a/ffserver_config.h
>> +++ b/ffserver_config.h
>> @@ -113,6 +113,7 @@ typedef struct FFServerConfig {
>>       AVDictionary *video_conf;     /* Values stored in video AVCodecContext.fields */
>>       AVDictionary *audio_opts;     /* AVOptions for audio encoder */
>>       AVDictionary *audio_conf;     /* Values stored in audio AVCodecContext.fields */
>> +    AVCodecContext *dummy_ctx;    /* Used internally to test AVOptions, not to be used anywere else */
>
> s/anywere/anywhere/g
>
> nit: . Not to be ....

Changed and pushed.



More information about the ffmpeg-devel mailing list