[FFmpeg-devel] Add Lame tag to the Xing/Info header of mp3 files.

[Michael Niedermayer]

On Fri, May 30, 2014 at 01:29:24PM -0700, Giovanni Motta wrote:
> This patch set adds to the Xing header the Lame info tag extension described here:
> http://gabriel.mp3-tech.org/mp3infotag.html (see "*Suggested Info Tag extension fields + layout* ").
> 

> The Lame info tag is necessary to add encoder delay and padding info to mp3 files (for gapless playback).

why is this not using AV_PKT_DATA_SKIP_SAMPLES ?
have you thought about mp3 in mkv and other containers than raw mp3 ?

also ideally there should be symmetry between the encoder and decoder
that is extra data used in demuxer -> decode and encoder -> muxer
should be of the same kind an format.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140531/b4cfe973/attachment.asc>