[FFmpeg-devel] [PATCH 6/6] x86: huffyuvdsp: fewer functions for x86_64

[Michael Niedermayer]

On Fri, May 30, 2014 at 05:35:47PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2014-05-30 17:27 GMT+02:00 Michael Niedermayer <michaelni at gmx.at>:
> >> When there are 2 functions that are <= SSE2, only one is needed for x86_64.
> >
> > is it worth the extra %if ?
> 
> Do you mean code clutter? Quoting Ronald:
> """
> As long as all this is under ARCH_X86_32 (it is in this patch), I don't
> mind. I mean, people still actively develop mod decoders, that stuff is
> even older.
> """

yes, clutter, it makes the relevant code harder to read/maintain, also
%ifs need maintaince and updating occasionally

and in the end its still just a half done thing
mmx is build even when its known at compile time that mmxext is
guranteed to be available for example

either way, as this seems popular, patch applied


> 
> I'd consider good practice to try and reduce total object size.
> Granted, it's not 1KB saved in a 75MB debug build that's going to
> change anything, but still, it slightly decreases my worries about my
> slow laptop hard drive. :)

i agree, smaller is better


thanks
[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140530/165f19f6/attachment.asc>