[FFmpeg-devel] [PATCH] MPEG-TS/-PS : better probing for duration and start-time for all streams in a container

[Michael Niedermayer]

On Mon, May 26, 2014 at 02:51:48PM +0000, Gaullier Nicolas wrote:
> Please see below my new proposal-patch:
> The first_dts is the reason why the start_time was stuck to the first packet,
> since update_initial_timestamps()  returned immediately without any further processing.
> I thus skiped this first_dts test.
> I then nearly replaced "x=y" with "x=FFMIN(x,y)" with appropriate checkings.
> I think it does not change the structure of the code, so it should be safe.
> Thank you,
> Nicolas

patch breaks "make fate"

--- ./tests/ref/fate/filter-yadif-mode0 2014-05-25 06:21:45.068355305 +0200
+++ tests/data/fate/filter-yadif-mode0  2014-05-28 14:16:51.449849725 +0200
@@ -1,31 +1,31 @@
 #tb 0: 1/25
-0,          9,          9,        1,   622080, 0x6331caee
-0,         10,         10,        1,   622080, 0xa459e690
-0,         11,         11,        1,   622080, 0x6429c648
-0,         12,         12,        1,   622080, 0xa49891ca
-0,         13,         13,        1,   622080, 0x2a887404
-0,         14,         14,        1,   622080, 0xe8d49705
-0,         15,         15,        1,   622080, 0x1b627835
-0,         16,         16,        1,   622080, 0x686858fd
-0,         17,         17,        1,   622080, 0x2675174f
-0,         18,         18,        1,   622080, 0x78470e7f
-0,         19,         19,        1,   622080, 0xffb366ec
-0,         20,         20,        1,   622080, 0xd575da72
-0,         21,         21,        1,   622080, 0x5fb297f7
-0,         22,         22,        1,   622080, 0xbac77ca0
-0,         23,         23,        1,   622080, 0x3276ed72
-0,         24,         24,        1,   622080, 0x264092b2
-0,         25,         25,        1,   622080, 0x20ba1094
-0,         26,         26,        1,   622080, 0x76cc3139
-0,         27,         27,        1,   622080, 0x469a4902
-0,         28,         28,        1,   622080, 0x0ed7b8f5
-0,         29,         29,        1,   622080, 0xdc51aeac
-0,         30,         30,        1,   622080, 0xee06aa36
-0,         31,         31,        1,   622080, 0x7372405f
-0,         32,         32,        1,   622080, 0x9e0ee776
-0,         33,         33,        1,   622080, 0x39e6d8c9
-0,         34,         34,        1,   622080, 0x51d9ac9a
-0,         35,         35,        1,   622080, 0x2b63441d
-0,         36,         36,        1,   622080, 0x58afbd5e
-0,         37,         37,        1,   622080, 0xb972f716
-0,         38,         38,        1,   622080, 0x6a6df129
+0,         10,         10,        1,   622080, 0x6331caee
+0,         11,         11,        1,   622080, 0xa459e690
+0,         12,         12,        1,   622080, 0x6429c648
+0,         13,         13,        1,   622080, 0xa49891ca
+0,         14,         14,        1,   622080, 0x2a887404
+0,         15,         15,        1,   622080, 0xe8d49705
+0,         16,         16,        1,   622080, 0x1b627835
+0,         17,         17,        1,   622080, 0x686858fd
+0,         18,         18,        1,   622080, 0x2675174f
+0,         19,         19,        1,   622080, 0x78470e7f
+0,         20,         20,        1,   622080, 0xffb366ec
+0,         21,         21,        1,   622080, 0xd575da72
+0,         22,         22,        1,   622080, 0x5fb297f7
+0,         23,         23,        1,   622080, 0xbac77ca0
+0,         24,         24,        1,   622080, 0x3276ed72
+0,         25,         25,        1,   622080, 0x264092b2
+0,         26,         26,        1,   622080, 0x20ba1094
+0,         27,         27,        1,   622080, 0x76cc3139
+0,         28,         28,        1,   622080, 0x469a4902
+0,         29,         29,        1,   622080, 0x0ed7b8f5
+0,         30,         30,        1,   622080, 0xdc51aeac
+0,         31,         31,        1,   622080, 0xee06aa36
+0,         32,         32,        1,   622080, 0x7372405f
+0,         33,         33,        1,   622080, 0x9e0ee776
+0,         34,         34,        1,   622080, 0x39e6d8c9
+0,         35,         35,        1,   622080, 0x51d9ac9a
+0,         36,         36,        1,   622080, 0x2b63441d
+0,         37,         37,        1,   622080, 0x58afbd5e
+0,         38,         38,        1,   622080, 0xb972f716
+0,         39,         39,        1,   622080, 0x6a6df129
Test filter-yadif-mode0 failed. Look at tests/data/fate/filter-yadif-mode0.err for details.
make: *** [fate-filter-yadif-mode0] Error 1
make: *** Waiting for unfinished jobs....

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140528/f01132e5/attachment.asc>