[FFmpeg-devel] [PATCH]Do not require pkg-config for libx265

[Clément Bœsch]

On Mon, May 26, 2014 at 10:42:47AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> As HEVC gets more common, this is starting to hit users.
> 
> Please comment, Carl Eugen

> diff --git a/Changelog b/Changelog
> index 3d416c4..d52f4ea 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -26,6 +26,7 @@ version <next>:
>  - native Opus decoder
>  - display matrix export and rotation api
>  - WebVTT encoder
> +- Do not require pkg-config for x265
>  
>  
>  version 2.2:
> diff --git a/configure b/configure
> index fae2f77..af88b79 100755
> --- a/configure
> +++ b/configure
> @@ -4695,7 +4695,7 @@ enabled libwebp           && require_pkg_config libwebp webp/encode.h WebPGetEnc
>  enabled libx264           && require libx264 x264.h x264_encoder_encode -lx264 &&
>                               { check_cpp_condition x264.h "X264_BUILD >= 118" ||
>                                 die "ERROR: libx264 must be installed and version must be >= 0.118."; }
> -enabled libx265           && require_pkg_config x265 x265.h x265_encoder_encode &&
> +enabled libx265           && require libx265 x265.h x265_encoder_encode -lx265 -lstdc++ &&
>                               { check_cpp_condition x265.h "X265_BUILD >= 13" ||
>                                 die "ERROR: libx265 version must be >= 13."; }
>  enabled libxavs           && require libxavs xavs.h xavs_encoder_encode -lxavs

x264 doesn't require -lstdc++ unless static. And if you have want a static
build you actually need -lm and -lrt as well. At least on my
system/configuration. It may also differs as x265 continue to be
developed.

    [~]☭ pkg-config --libs x265
    -lx265 
    [~]☭ pkg-config --static --libs x265
    -lx265 -lstdc++ -lm -lrt 

Not relying on pkg-config will break this.

So, what's the problem with pkg-config requirement? It's 100kb tool available
on every system.

I think what you want instead is a configure script that warn for the non
presence of pkg-config when an external library is enabled. We have such
warning IIRC, but way too late.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140526/371fe1d0/attachment.asc>