[FFmpeg-devel] [PATCH] x86: dsputilenc: convert ff_sse{8, 16}_mmx() to yasm

[Michael Niedermayer]

On Sun, May 25, 2014 at 07:34:59PM +0200, Christophe Gisquet wrote:
> Hi,
> 
> 2014-05-24 2:18 GMT+02:00 Timothy Gu <timothygu99 at gmail.com>:
> > +int ff_sse8_mmx(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2,
> > +                int line_size, int h);
> > +int ff_sse16_mmx(MpegEncContext *v, uint8_t *pix1, uint8_t *pix2,
> > +                 int line_size, int h);
> 
> this does not compile with --disable-yasm:
> libavcodec/libavcodec.a(dsputilenc_mmx.o): In function `nsse8_mmx':
> libavcodec/x86/dsputilenc_mmx.c:318: undefined reference to `ff_sse8_mmx'
> libavcodec/libavcodec.a(dsputilenc_mmx.o): In function `nsse16_mmx':
> libavcodec/x86/dsputilenc_mmx.c:305: undefined reference to `ff_sse16_mmx'
> 
> This also results in kind of messy code because some functions now
> rely on both inline asm and yasm. To fix this, ideally hf_noise* would
> be ported to yasm too.
> 

> Meanwhile, it may be good to revert this change.

reverted

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140525/0287b059/attachment.asc>