[FFmpeg-devel] [PATCH 3/4] Fix compilation error around struct visibility when VDPAU disabled.

[Dale Curtis]

On Wed, May 21, 2014 at 5:00 PM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Wed, May 21, 2014 at 03:36:44PM -0700, Dale Curtis wrote:
> > On Tue, May 20, 2014 at 8:13 PM, Michael Niedermayer <michaelni at gmx.at
> >wrote:
> >
> > > On Tue, May 20, 2014 at 12:03:58PM -0700, Dale Curtis wrote:
> > > > ---
> > > >  libavcodec/vdpau_internal.h | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > >
> > > how can this failure be reproduced ?
> > > i tried "./configure  --disable-vdpau" but that worked fine
> > >
> > >
> > You'll need to build with clang -Wall -Werror modulo disabling these
> > warnings:
> >
> >
> https://code.google.com/p/chromium/codesearch#chromium/src/third_party/ffmpeg/ffmpeg.gyp&l=182
> >
> > Although I'm not sure if all of FFmpeg will build with -Wall -Werror plus
> > those warnings disabled; those flags only build the subset of FFmpeg used
> > by Chrome. Here are the exact errors:
>
> this sounds a bit complicated, patch applied and i added a
> simplification on top, please test
> if it doesnt work ill revert my simplification
>
>
Looks good, thanks!

- dale