[FFmpeg-devel] [PATCH] x86: kill fpel_mmx.c

James Almer jamrial at gmail.com
Tue May 20 22:23:00 CEST 2014


On 20/05/14 3:58 PM, Michael Niedermayer wrote:
> also did you benchmark the change this patch makes ?
> the original code was quite finetuned IIRC someone back then
> tested all kinds of instruction orders and complex addressing vs
> increasing the pointers, and what we had was the best found i that
> testing ...
> that was of course with the cpus of that time, but still a mmx only
> or mmx2 only box for which some of this gets used could be similar
> 
> So we should make sure we dont worsen this ...

mmx only boxes are Pentium 2 amd AMD K6 computers. mmxext only boxes 
are AMD K7 (pre Athlon XP) computers. The amount of such computers in 
use out there that would end up using ffmpeg 2.3 or newer in any way 
is minimal.

So even if this patch means a small performance hit for those or even 
newer computers, as long as it's not a big one it's a very welcome 
change. Especially for compilers like msvc.


More information about the ffmpeg-devel mailing list