[FFmpeg-devel] [PATCH v2] avcodec/webvttenc: add webvtt encoder

[Clément Bœsch]

On Tue, May 13, 2014 at 04:00:52PM -0700, ffmpeg at tmm1.net wrote:
> From: Aman Gupta <ffmpeg at tmm1.net>
> 
> Mostly a copy of the srt encoder in libavcodec/srtenc.c.

If so...

[...]
> diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c
> new file mode 100644
> index 0000000..e4379ef
> --- /dev/null
> +++ b/libavcodec/webvttenc.c
> @@ -0,0 +1,255 @@
> +/*
> + * WebVTT subtitle encoder
> + * Copyright (c) 2014  Aman Gupta <aman at tmm1.net>
> + *

You should add Aurelien's copyright here.

[...]
> diff --git a/libavformat/webvttenc.c b/libavformat/webvttenc.c
> index bd19a83..3c45910 100644
> --- a/libavformat/webvttenc.c
> +++ b/libavformat/webvttenc.c
> @@ -93,6 +93,7 @@ AVOutputFormat ff_webvtt_muxer = {
>      .long_name         = NULL_IF_CONFIG_SMALL("WebVTT subtitle"),
>      .extensions        = "vtt",
>      .mime_type         = "text/vtt",
> +    .flags             = AVFMT_TS_NONSTRICT,

Note: it seems the srt muxer also has the VARIABLE_FPS flag, but I wonder
if it has any effect...

[...]

Patch LGTM otherwise, sorry for the delay. I'll add the copyright, bump
lavc, and apply in a day or two unless I see an objection.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140519/b25b34a0/attachment.asc>