[FFmpeg-devel] [PATCH] MPEG-TS/-PS : better probing for duration and start-time for all streams in a container

[Carl Eugen Hoyos]

Gaullier Nicolas <nicolas.gaullier <at> arkena.com> writes:

> +	if (pts != AV_NOPTS_VALUE) {

tabs cannot be committed to our repository, 
please remove them, indentation is four spaces.

There is a script tools/patcheck that tells you 
about such issues.

> +		if (st->start_time == AV_NOPTS_VALUE) {
> +			st->start_time = pts;
> +		}
> +		else  {

This should be:
    } else {
(in one line)

> +	av_log(NULL, AV_LOG_WARNING, "stream %d : no 
> PTS found at end of file, duration not set\n", i);

av_log context should not be NULL.

>          ret = read_frame_internal(ic, &pkt1);
> +		
>          if (ret == AVERROR(EAGAIN))

Please don't add empty lines.

Trying to apply your patch here indicates that it is 
made for an older version of FFmpeg, please update.
(Since applying works you could wait for a "real" review.)

Carl Eugen