[FFmpeg-devel] Use rac_get_prob_branchy in any conditional branches

Michael Niedermayer michaelni at gmx.at
Tue May 13 16:09:43 CEST 2014


On Mon, Apr 07, 2014 at 06:21:10PM +1000, Matt Oliver wrote:
> After a discussion in another thread about some optimisation to
> vp56_rac_get_prob it was pointed out by Reimar that all conditional
> branches should be using the rac_get_prob_branchy function variant. Im
> going to quote Reimar directly on this one:
> 
> "That should be wrong. All the ifs should be using the _branchy variant"
> 
> Anyway many of the older vp5 and vp6 codecs are not using the _branchy
> variant at all. So before this conversation was forgotten and relegated to
> the mailing list archives I did a quick replace and updated all instance to
> the branchy version where that function was used in a if statement.

>  vp5.c  |   26 +++++++++++++-------------
>  vp56.c |    8 ++++----
>  vp56.h |    2 +-
>  vp6.c  |   30 +++++++++++++++---------------
>  vp8.c  |    2 +-
>  5 files changed, 34 insertions(+), 34 deletions(-)
> 86617a94bd2c17ec6215121bdfbfe953245f8708  Use-rac_get_prob-branchy-version-when-used-within-a-.patch
> From 24c0a2122825d452091a84cb13e7980eb1429af4 Mon Sep 17 00:00:00 2001
> From: Matt Oliver <protogonoi at gmail.com>
> Date: Mon, 7 Apr 2014 16:57:08 +1000
> Subject: [PATCH] Use rac_get_prob branchy version when used within a
>  conditional branch.

applied

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140513/78d0b376/attachment.asc>


More information about the ffmpeg-devel mailing list