[FFmpeg-devel] [PATCH] configure: Allow log2 with msvc12 onwards

[Matt Oliver]

On 12 May 2014 12:11, Michael Niedermayer <michaelni at gmx.at> wrote:

> On Sun, May 11, 2014 at 05:46:34PM +1000, Matt Oliver wrote:
> > Currently log2 math function is blanket disabled if the msvcrt is
> detected.
> > From the comments on the initial patch that included this behaviour it
> was
> > to fix a bug that occurred with MSVC 2010 x64. However this behaviour is
> no
> > longer correct with msvc12 onwards as it now has a C99 compliant math
> libc
> > (and therefore working log2). So disabling it in this case is incorrect.
> > Attached patch rectifies this by only disabling log2 if a pre-msvc12 libc
> > version is detected.
>
> >  configure |    4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > c6cec8e6376885b56b59600ce7bc29e157a25fbe
>  configure-Allow-log2-with-msvc12-onwards.patch
> > From b8ebb3b00ddc026afb1de2fbff866419103a4450 Mon Sep 17 00:00:00 2001
> > From: Matt Oliver <protogonoi at gmail.com>
> > Date: Sun, 11 May 2014 17:40:20 +1000
> > Subject: [PATCH] configure: Allow log2 with msvc12 onwards.
>
> applied
>
> thx


 Slight addendum to last patch as the log2 disable should be added after
the math_func check, msvc11 and msvc12 all work fine already. This should
just enforce MSVC 2010 better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: configure-Delay-msvcrt-log2-check-till-after-math_fu.patch
Type: application/octet-stream
Size: 1127 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140512/4714c7f7/attachment.obj>