[FFmpeg-devel] [PATCH] Message queue API

[Nicolas George]

Le quintidi 15 floréal, an CCXXII, Clément Bœsch a écrit :
> I'm not sure an empty struct is valid in C, you may need to add a dummy
> field or something to avoid chocking with random compilers.

I did check with gcc, and it did not complain even in pedantic mode, but
after a more thorough glance to the standard it seems indeed necessary.

> Those should probably be size_t, but it's not important.

The fifo API uses ints.

> BTW, I know this is a pain to change now, but the number of element is
> often (always?) put before the element size.

Changed.

> It's static so please drop the av_ prefix
> ditto

I prefer to keep the identical name with the _unlocked versions.

Updated patches attached, for the order of arguments.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavu-add-thread-message-API.patch
Type: text/x-diff
Size: 10846 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140510/06851f23/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ffmpeg-use-thread-message-API.patch
Type: text/x-diff
Size: 6384 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140510/06851f23/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20140510/06851f23/attachment.asc>