[FFmpeg-devel] Patch: Inline asm fixes for Intel compiler on Windows

Ronald S. Bultje rsbultje at gmail.com
Sat Mar 29 18:12:45 CET 2014


Hi,

On Sat, Mar 29, 2014 at 12:18 AM, Matt Oliver <protogonoi at gmail.com> wrote:

> OK here is a slightly different approach to fixing the missing CLTD
> instruction support for icl inline asm. After looking into the situation
> further I noticed that CLTD is only used in 2 places and in both places it
> is for generating a sign mask.


Why not create a macro that expands to the correct instruction supported
for each compiler?

#if some stuff
#define CLTD_CDQ "cdq"
#else
#define CLTD_CDQ "cltd"
#endif

We do that for e.g. register size detection (e.g. REG_a for eax vs. rax), I
think it's fine here also.

Ronald


More information about the ffmpeg-devel mailing list